forked from OpenFAST/openfast
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging Andy's MDv2+SrvDLin to Matt's MDv2 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not run (seg faults) since there are old routines still that need updating.
- new order: Blade, nacelle, tower, substructure - The order is very important in the linearization, so I reordered simply to keep it consistent everywhere.
- Update SrvD_JacobianPInput - still missing the dYdu user channels - also missing dXdu - Update GetOP for dx_op matrix - Updates to FAST_Lin.f90 so it now compiles and actually runs!!!! Just produces rubbish... There was some confusion on a prior commit about where the logmapping flag from FAST_Lin goes (doesn't go with the u% stuff, only for y% motion DCMs)
- this is necessary so I can set outputs for single StC during linearization (speeds up code)
- think this is working for BStC
- but u (unerturbed) was getting used to set the StC motion input perturbations :(
Increase rank of arrays so that blade number and StC instance are tracked. This simplifies assembling of jacobians in glue code.
Also a few blank lines moved for easier git comparisons
fix a few typos in Linear_SrvD_InputSolve_du, and add some comments
SStC loads were mapped to u_ED_PlatformPtMesh_2 which was then overwritten in FAST_Solver.f90 when HD loads were calculated and added to the platform reference point.
- Some states may not have been set to zero when unused (z-dof when Omni for example)
- Tower Line2 was incorrectly linearized. Changed to Linearize_Line2_to_Point from Linearize_Point_to_Point (this was causing NaNs in the A & C matrices in testing) - Incorrect indexing (Jac_Idx_BStC_y should have been Jac_Idx_BStC_u) in dUdu - Wrong tower mesh in the linearization.
Excellent! Looks like you figured it out. I had changed the branch name after creating #4, and that closed the PR instead of updating which branch the PR was based on... sorry about that. |
mattEhall
added a commit
that referenced
this pull request
Aug 25, 2021
Merging Andy's MDv2+SrvDLin to Matt's MDv2
mattEhall
pushed a commit
that referenced
this pull request
Jan 16, 2024
Fix potential numerical issues with acos in HD/SeaSt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating Andy's pull request #5: "I have not not tested this other than a quick compile. There were only a few changes in the FAST_Lin.f90 file where we both had to add to subroutines."