Minor compilation bug fixes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattEhall, I don't know how important this PR is to the project, but figured I'd throw it out there just in case you wanted an easy merge. |
|
Hi @nikhar-abbas, thanks for this! Seems like I should merge this in for the sake of keeping this branch up-to-date. A different approach will be used to provide these capabilities in the main branch in the future, but still want to keep this branch as useful as possible until then. Just one question: is the private to public change in Waves.f90 necessary? The variables from Waves used by MoorDyn are individually declared as public, so I thought they would be available without having to make the entire Waves module public. |
|
@mattEhall Just checking - will this be merged anytime soon? |
mattEhall
pushed a commit
that referenced
this pull request
Jan 16, 2024
Bug Fix: Wrong ErrStat preventing wave elev VTK outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This fixes some the compiler problems that were discussed in OpenFAST#888.
Related issue, if one exists
OpenFAST#888
Impacted areas of the software
HydroDyn, MoorDyn
Additional supporting information
Test results, if applicable