Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set suggested sort on pre and post threads #22

Merged

Conversation

toddrob99
Copy link
Contributor

No description provided.

@toddrob99 toddrob99 mentioned this pull request Apr 20, 2017
@mattabullock mattabullock merged commit 8ec4040 into mattabullock:master Aug 4, 2017
mattabullock pushed a commit that referenced this pull request Aug 4, 2017
Update fork master from upstream master
@toddrob99
Copy link
Contributor Author

This one also appears to have been phantom merged.

@toddrob99
Copy link
Contributor Author

I think both #22 (this pull request) and #24 must have been "merged" when you merged #30. After that, I saw the Pull Requests tab change from 4 to 1.

I also think #22 and #24 both had conflicts to resolve.

Should I submit new pull requests for those changes, or are you able to re-open them?

@mattabullock
Copy link
Owner

Yeah I believe that's the case as well. I think you'll have to open new ones, but it may be difficult to get the changes to show in the diff again because they were already added... one way to find out!

@toddrob99
Copy link
Contributor Author

Replaced with #32

@toddrob99 toddrob99 deleted the suggested-sort-pre-post-threads branch August 4, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants