Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor blink animation. #306

Merged
merged 5 commits into from
May 26, 2018
Merged

Conversation

anteprimorac
Copy link
Contributor

@anteprimorac anteprimorac commented Aug 28, 2017

Requirements

Description of the Change

This pull request fixes cursor blink animation by toggling blink class on .typed-cursor element.

@anteprimorac
Copy link
Contributor Author

This PR should fix #291.

@mattboldt
Copy link
Owner

So the main fix here is the usage of animationIterationCount? That wasn't working on the linked issue? Also, could you renamed the .blink class to something more specific? That's too generic of a name to set globally.

@anteprimorac
Copy link
Contributor Author

Hi @mattboldt ,
yes, changing animationIterationCount doesn't reset the animation.
.blink is now replaced with .typed-cursor--blink.

Do you want this in separate branch?

@dbkaplun
Copy link

dbkaplun commented Mar 1, 2018

Any progress on this? I can confirm that the issue is related to animationIterationCount.

@anteprimorac
Copy link
Contributor Author

Hi @mattboldt, can you merge this PR?

@mattboldt mattboldt merged commit 99d12e0 into mattboldt:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants