Use rake to invoke rake tasks, not rails #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for tomo's `rake` helper, and the intent of that method, is that it runs `bundle exec rake`. However this `rake` helper was in fact running `bundle exec rails` instead. This was a mistake. Fix this so that the `rake` helper, and tasks that depend on it (e.g. `rails:db_migrate`, `rails:db_seed`, etc.) use `bundle exec rake` instead of `bundle exec rails` as originally intended. This also makes tomo compatible with older versions of Rails, before the `rails` was smart enough to be able to invoke rake tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for tomo's
rakehelper, and the intent of that method, is that it runsbundle exec rake. However thisrakehelper was in fact runningbundle exec railsinstead. This was a mistake.Fix this so that the
rakehelper, and tasks that depend on it (e.g.rails:db_migrate,rails:db_seed, etc.) usebundle exec rakeinstead ofbundle exec railsas originally intended.This also makes tomo compatible with older versions of Rails, before the
railswas smart enough to be able to invoke rake tasks.