Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from = 0.82.0 to = 0.85.1 #140

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Update rubocop requirement from = 0.82.0 to = 0.85.1 #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45db29e
Update rubocop requirement from = 0.82.0 to = 0.85.1
dependabot-preview[bot] Jun 13, 2020
3890a0c
Enable new cops
mattbrictson Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ AllCops:
- "tmp/**/*"
- "vendor/**/*"

Layout/EmptyLinesAroundAttributeAccessor:
Enabled: true

Layout/HashAlignment:
EnforcedColonStyle:
- table
Expand All @@ -29,6 +32,12 @@ Layout/SpaceAroundEqualsInParameterDefault:
Layout/SpaceAroundMethodCallOperator:
Enabled: true

Lint/DeprecatedOpenSSLConstant:
Enabled: true

Lint/MixedRegexpCaptureTypes:
Enabled: true

Lint/RaiseException:
Enabled: true

Expand Down Expand Up @@ -102,6 +111,15 @@ Style/HashTransformValues:
Style/NumericPredicate:
Enabled: false

Style/RedundantRegexpCharacterClass:
Enabled: true

Style/RedundantRegexpEscape:
Enabled: true

Style/SlicingWithRange:
Enabled: true

Style/StringLiterals:
EnforcedStyle: double_quotes

Expand Down
8 changes: 4 additions & 4 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace :bump do
replace_in_file ".travis.yml", /bundler -v (\S+)/ => version
replace_in_file ".circleci/config.yml", /bundler -v (\S+)/ => version
replace_in_file ".circleci/Dockerfile", /bundler -v (\S+)/ => version
replace_in_file "Gemfile.lock", /^BUNDLED WITH\n\s+([\d\.]+)$/ => version
replace_in_file "Gemfile.lock", /^BUNDLED WITH\n\s+([\d.]+)$/ => version
end

task :ruby do
Expand All @@ -43,9 +43,9 @@ namespace :bump do

replace_in_file "tomo.gemspec", /ruby_version = ">= (.*)"/ => lowest
replace_in_file ".rubocop.yml", /TargetRubyVersion: (.*)/ => lowest_minor
replace_in_file ".circleci/config.yml", %r{circleci/ruby:([\d\.]+)} => latest
replace_in_file ".circleci/Dockerfile", %r{circleci/ruby:([\d\.]+)} => latest
replace_in_file "docs/comparisons.md", /ruby version\s*\|\s*([\d\.]+)/i => lowest_minor
replace_in_file ".circleci/config.yml", %r{circleci/ruby:([\d.]+)} => latest
replace_in_file ".circleci/Dockerfile", %r{circleci/ruby:([\d.]+)} => latest
replace_in_file "docs/comparisons.md", /ruby version\s*\|\s*([\d.]+)/i => lowest_minor

travis = YAML.safe_load(open(".travis.yml"))
travis["rvm"] = RubyVersions.latest_supported_patches + ["ruby-head"]
Expand Down
2 changes: 1 addition & 1 deletion tomo.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "minitest-ci", "~> 3.4"
spec.add_development_dependency "minitest-reporters", "~> 1.3"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rubocop", "0.82.0"
spec.add_development_dependency "rubocop", "0.85.1"
spec.add_development_dependency "rubocop-minitest", "0.9.0"
spec.add_development_dependency "rubocop-performance", "1.6.1"
end