Randomize tmp_path for more security #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tomo setup` used to stage files in `/tmp/tomo`, which is a stable and predictable path. Since `/tmp` is globally writable, this path could be exploited by another process to interfere with the `tomo setup` command. To prevent this, tomo will now use a randomly generated temporary path, like this: `/tmp/tomo-a4DBHX0P`. If you prefer the old behavior, or wish to use a different path, set the `tmp_path` in your tomo config, like this: ```ruby set tmp_path: "/tmp/tomo" ```
mattbrictson
added
⚠️ Breaking
mattbrictson
changed the title
:tmp_path for more security
mattbrictson
changed the title
:tmp_path for more security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomo setupused to stage files in/tmp/tomo, which is a stable and predictable path. Since/tmpis globally writable, this path could be exploited by another process to interfere with thetomo setupcommand.To prevent this, tomo will now use a randomly generated temporary path, like this:
/tmp/tomo-a4DBHX0P.If you prefer the old behavior, or wish to use a different path, set the
tmp_pathin your tomo config, like this: