Fix "uninitialized constant" errors for StringIO and SimpleDelegator #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In instances when tomo is used without a Gemfile, or is used with a Gemfile that contains very few gems, running `tomo` might result in an "uninitialized constant" crash for `StringIO` or `SimpleDelegator`. This happens because tomo is trying to use these constants without explicitly `require`-ing them. By luck, gems in a typical Gemfile will already require these, so by the time tomo runs, they have already been loaded. But this is not guaranteed. Fix by using the proper `require` statements to insure that these constants are loaded.
mattbrictson
added
🐛 Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In instances when tomo is used without a Gemfile, or is used with a Gemfile that contains very few gems, running
tomomight result in an "uninitialized constant" crash forStringIOorSimpleDelegator.This happens because tomo is trying to use these constants without explicitly
require-ing them. By luck, gems in a typical Gemfile will already require these, so by the time tomo runs, they have already been loaded. But this is not guaranteed.Fix by using the proper
requirestatements to insure that these constants are loaded.