Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from 1.57.2 to 1.58.0 #415

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Update rubocop requirement from 1.57.2 to 1.58.0 #415

merged 1 commit into from
Dec 1, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2023 •
edited
Loading

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.58

New features

Bug fixes

  • #12372: Fix a false negative for Lint/Debugger when used within method arguments a begin...end block. (@​koic)
  • #12378: Fix a false negative for Style/Semicolon when a semicolon at the beginning of a lambda block. (@​koic)
  • #12146: Fix a false positive for Lint/FloatComparison when comparing against zero. (@​earlopain)
  • #12404: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue in do-end numbered block in a method. (@​koic)
  • #12374: Fix a false positive for Layout/SpaceBeforeSemicolon when a space between an opening lambda brace and a semicolon. (@​koic)
  • #12326: Fix an error for Style/RedundantDoubleSplatHashBraces when method call for parenthesized no hash double double splat. (@​koic)
  • #12361: Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments. (@​koic)
  • #12324: Fix an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute. (@​koic)
  • #12322: Fix an error for Style/CombinableLoops when looping over the same data for the third consecutive time or more. (@​koic)
  • #12366: Fix a false negative for Layout/ExtraSpacing when a file has exactly two comments. (@​eugeneius)
  • #12373: Fix a false negative for Lint/SymbolConversion when using string interpolation. (@​earlopain)
  • #12402: Fix false negatives for Style/RedundantLineContinuation when redundant line continuations for a block are used, especially without parentheses around first argument. (@​koic)
  • #12311: Fix false negatives for Style/RedundantParentheses when parentheses around logical operator keywords in method definition. (@​koic)
  • #12394: Fix false negatives for Style/RedundantReturn when lambda (->) ending with return. (@​koic)
  • #12377: Fix false positives for Lint/Void when a collection literal that includes non-literal elements in a method definition. (@​koic)
  • #12407: Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain. (@​koic)
  • #12409: Fix an incorrect autocorrect for Lint/SafeNavigationChain when ordinary method chain exists after safe navigation leading dot method call. (@​koic)
  • #12363: Fix incorrect rendering of HTML character entities in HTMLFormatter formatter. (@​koic)
  • #12424: Make Style/HashEachMethods aware of safe navigation operator. (@​koic)
  • #12413: Make Style/InverseMethods aware of safe navigation operator. (@​koic)
  • #12408: Make Style/MapToHash aware of safe navigation operator. (@​koic)

Changes

  • #12328: Make Style/AutoResourceCleanup aware of Tempfile.open. (@​koic)
  • #12412: Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults. (@​fatkodima)
  • #12410: Enhance Lint/SelfAssignment to check attribute assignment and key assignment. (@​fatkodima)
  • #12370: Make Style/HashEachMethods aware of unused block value. (@​koic)
  • #12380: Make Style/RedundantParentheses aware of lambda or proc. (@​koic)
  • #12421: Make Style/SelfAssignment aware of %, ^, <<, and >> operators. (@​koic)
  • #12305: Require rubocop-ast version 1.30 or greater. (@​sambostock)
  • #12337: Supports EnforcedStyleForRationalLiterals option for Layout/SpaceAroundOperators. (@​koic)
  • #12296: Support RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, and RedundantBlockArgumentNames options for Style/ArgumentsForwarding. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.58.0 (2023-12-01)

New features

Bug fixes

  • #12372: Fix a false negative for Lint/Debugger when used within method arguments a begin...end block. ([@​koic][])
  • #12378: Fix a false negative for Style/Semicolon when a semicolon at the beginning of a lambda block. ([@​koic][])
  • #12146: Fix a false positive for Lint/FloatComparison when comparing against zero. ([@​earlopain][])
  • #12404: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue in do-end numbered block in a method. ([@​koic][])
  • #12374: Fix a false positive for Layout/SpaceBeforeSemicolon when a space between an opening lambda brace and a semicolon. ([@​koic][])
  • #12326: Fix an error for Style/RedundantDoubleSplatHashBraces when method call for parenthesized no hash double double splat. ([@​koic][])
  • #12361: Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments. ([@​koic][])
  • #12324: Fix an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute. ([@​koic][])
  • #12322: Fix an error for Style/CombinableLoops when looping over the same data for the third consecutive time or more. ([@​koic][])
  • #12366: Fix a false negative for Layout/ExtraSpacing when a file has exactly two comments. ([@​eugeneius][])
  • #12373: Fix a false negative for Lint/SymbolConversion when using string interpolation. ([@​earlopain][])
  • #12402: Fix false negatives for Style/RedundantLineContinuation when redundant line continuations for a block are used, especially without parentheses around first argument. ([@​koic][])
  • #12311: Fix false negatives for Style/RedundantParentheses when parentheses around logical operator keywords in method definition. ([@​koic][])
  • #12394: Fix false negatives for Style/RedundantReturn when lambda (->) ending with return. ([@​koic][])
  • #12377: Fix false positives for Lint/Void when a collection literal that includes non-literal elements in a method definition. ([@​koic][])
  • #12407: Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain. ([@​koic][])
  • #12409: Fix an incorrect autocorrect for Lint/SafeNavigationChain when ordinary method chain exists after safe navigation leading dot method call. ([@​koic][])
  • #12363: Fix incorrect rendering of HTML character entities in HTMLFormatter formatter. ([@​koic][])
  • #12424: Make Style/HashEachMethods aware of safe navigation operator. ([@​koic][])
  • #12413: Make Style/InverseMethods aware of safe navigation operator. ([@​koic][])
  • #12408: Make Style/MapToHash aware of safe navigation operator. ([@​koic][])

Changes

  • #12328: Make Style/AutoResourceCleanup aware of Tempfile.open. ([@​koic][])
  • #12412: Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults. ([@​fatkodima][])
  • #12410: Enhance Lint/SelfAssignment to check attribute assignment and key assignment. ([@​fatkodima][])
  • #12370: Make Style/HashEachMethods aware of unused block value. ([@​koic][])
  • #12380: Make Style/RedundantParentheses aware of lambda or proc. ([@​koic][])
  • #12421: Make Style/SelfAssignment aware of %, ^, <<, and >> operators. ([@​koic][])
  • #12305: Require rubocop-ast version 1.30 or greater. ([@​sambostock][])
  • #12337: Supports EnforcedStyleForRationalLiterals option for Layout/SpaceAroundOperators. ([@​koic][])
  • #12296: Support RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, and RedundantBlockArgumentNames options for Style/ArgumentsForwarding. ([@​koic][])

1.57.2 (2023-10-26)

Bug fixes

  • #12274: Fix a false positive for Lint/Void when each's receiver is an object of Enumerator to which filter has been applied. ([@​koic][])
  • #12291: Fix a false positive for Metrics/ClassLength when a class with a singleton class definition. ([@​koic][])

... (truncated)

Commits
  • f27164b Cut 1.58
  • 73b0876 Update Changelog
  • 19daa1c Add new Lint/LiteralAssignmentInCondition cop
  • c8d2d77 [Fix #12424] Make Style/HashEachMethods aware of safe navigation operator
  • 3db23fa Merge pull request #12422 from fatkodima/optimize-tests
  • 7f0a589 Optimize rspec tests
  • 4753e92 Merge pull request #12421 from koic/make_style_self_assignment_aware_of_some_...
  • 2f9a2d2 Make Style/SelfAssignment aware of some operators
  • a31a37c Merge pull request #12387 from Earlopain/fix-zero-method-for-float-comparison
  • 7a66f24 [Fix #12146] Fix a false positive for Lint/FloatComparison
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the 🏠 Housekeeping Non-user facing cleanup and maintenance label Dec 1, 2023
@dependabot
Update rubocop requirement from 1.57.2 to 1.58.0
29cf119 
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.57.2...v1.58.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.58.0 branch from 3e6b3aa to 29cf119 Compare December 1, 2023 15:01
@kodiakhq kodiakhq bot merged commit c5ab255 into main Dec 1, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the dependabot/bundler/rubocop-1.58.0 branch December 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏠 Housekeeping Non-user facing cleanup and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants