Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FrozenError when using interactive environment selector #452

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

mattbrictson
Copy link
Owner

When running tomo deploy in a multi-environment project with no environment explicitly specified, tomo prompts:

Choose an environment: 
❯ staging
  production

Interacting with this menu with the keyboard would result in an error:

forwardable.rb:240:in 'String#clear': can't modify frozen String: "" (FrozenError)
	from forwardable.rb:240:in 'Tomo::Console::KeyReader#clear'

This is because the internal buffer used by KeyReader was frozen as a side effect of #446.

Fix by marking buffer as mutable.

@mattbrictson mattbrictson added 🐛 Bug Fix Fixes a bug automerge Automatically merge this PR once all required checks pass labels Jun 22, 2024
@kodiakhq kodiakhq bot merged commit 61c59e3 into main Jun 22, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the bugs/fix-frozen-error branch June 22, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge this PR once all required checks pass 🐛 Bug Fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant