switch to github actions; test on a matrix; run eslint in CI #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! |
|
@mattcg whoops, turns out i should be using the coveralls github action instead of |
Merged
|
#18 fixes coverage; still working on the babel change. |
|
→ #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Note that the actions may not run on this PR until they're in the master branch of this repo, but you can view the results here: https://github.com/ljharb/language-tags/actions (you'll note the tests fail solely because coveralls isn't enabled on my fork)
This is the first PR to address #15 (comment); after this lands, I'll put up another that adds babel and restores older engines compatibility.
After this merges, you can add linting and tests as required status checks.