-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display 'intro' Snippets automatically after parsing the job description. #1
Comments
I would like to work on this enhancement if that's OK. Thanks! |
@Brechy Please do, thanks! |
hi @Brechy, how are you doing on this? |
Doing OK, I would like to have it in soon but its my first contribution and
I think there is a learning curve :)
Thanks for checking in with me!
…On Tue, Oct 16, 2018 at 11:13 AM Matt Cheah ***@***.***> wrote:
hi @Brechy <https://github.com/Brechy>, how are you doing on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXcSIFN6rtV8CnB_5PN3ZWSV5B0ckYoMks5uliHDgaJpZM4Vo_vc>
.
--
Warm regards,
Brechin A.
|
@mattcheah Is this up for grabs? |
@bhshkh yeah go ahead! Doesn't look like it's being worked on right now. Please let me know if you need help or would like any advice on where to start learning about how the structure of the app works. Good luck! |
Hi @mattcheah , is it still open ? If it still open can i take this? |
@ChellappanRajan go ahead! It’s been about a year since I’ve worked on this so let me know if everything is working alright for you. |
I am able to run locally and made those changes, do i need any permission to raise PR? |
…omatically visible after parsing the job description and the job description can be displayed if the user clicks on the description panel as an accordian
Currently, no snippets in the database are shown after parsing the job description, and the user must click on "Show Snippets" for a specific category to show any cover letter snippets in the database.
Since most users would always start off with an introduction, the first category of snippets to show from the database should be the "intro" snippets. It should show immediately after parsing the job description, not just after the "Show Snippets" button is clicked.
The logic for this is located in the
ResultsComponent
and retrieves records form theDatabaseService.database
object.A callback can be initiated after the
ParseDescriptionService
is finished, which runs the functiondisplaySnippets('intro')
inResultsComponent
, or it can be done some other way.I'd be happy to help out with anyone who wants to take this on.
The text was updated successfully, but these errors were encountered: