-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ASWebAuthenticationSession #335
Support ASWebAuthenticationSession #335
Conversation
Hi there, thanks for the PR. I just quickly looked at it and there seems like quite a bit of code duplication and I wonder if there's a cleaner way to support these authentication methods across different platforms. |
@meteochu By the way, do you think we should support ASWebAuthenticationSession to iOS with this pull request? I think we should do it as soon as possible according to apple's references. |
I've actually not looked at ASWebAuthenticationSession in the past. I just gave it a quick glance and it does seem quite promising. That said, I think this could be part of a big clean-up in the project that potentially supports Twitter API v2, as well as making this the default authentication to remove friction with the callbacks and to better support SwiftUI. I don't really have the time just yet to look at all of it but am happy to explore at some point. |
- Removed code duplication as much as possible. - Improved Demo App and made the structure of the iOS demo and the macOS demo similar.
@meteochu |
@meteochu Thank you for reviewing. How about my updates? |
Sorry about the delay, got a bit busy wrapping up my academics. The rest of the changes look good to me, once you apply the last change (revert the version change), I'll be happy to merge it :) |
I implemented to solve this issue #334
I also updated the SwifterDemoMac.