Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic validation #106

Closed
wants to merge 1 commit into from
Closed

Conversation

evanchooly
Copy link

This is some basic validation. There are a few different ways it could probably go but at least the core of it is there to start things rolling.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.48%) when pulling 8bf3a79 on evanchooly:master into 617a748 on lviggiano:master.

@lviggiano
Copy link
Collaborator

Thanks for this.

This is a long awaited feature, I am thinking to start a parallel branch to design this, then we can merge it on master.

I'll take some time to review this pull request, since lately I have not very much available time to dedicate to this project.

Luigi

@lviggiano lviggiano force-pushed the master branch 6 times, most recently from df63501 to 3ef11bd Compare July 22, 2015 16:48
@lviggiano
Copy link
Collaborator

Thanks for this, but we need something more comprehensive. Sorry for the long delay, getting back to this. This feature needs careful design. Thanks for your help.

@lviggiano lviggiano closed this Jun 14, 2016
@lviggiano lviggiano mentioned this pull request May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants