Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#110 add system properties and enviroment variable as sources #122

Merged
merged 8 commits into from
May 6, 2016
Merged

#110 add system properties and enviroment variable as sources #122

merged 8 commits into from
May 6, 2016

Conversation

gintau
Copy link

@gintau gintau commented Apr 1, 2015

I add system properties and environment variable into sources. As suggested by @kevin-canadian, I use system:properties and system:env as their uri.

I suppose env vars are not updated during a process, so only system properties are hot-reloadable.

@lviggiano
Copy link
Collaborator

Hi. I've been off from this project since some time, I just noticed this pull request. I'll look into it asap.

@lviggiano lviggiano force-pushed the master branch 6 times, most recently from df63501 to 3ef11bd Compare July 22, 2015 16:48
@lviggiano
Copy link
Collaborator

I like the change you introduced, and I will merge it as soon as I verified why this build has failed on Oracle JDK 7:

https://travis-ci.org/lviggiano/owner/builds/56682901

Also we need some documentation to be added to show how to use it. There is a sub module that contains the website documentation here, and it is open to contributions: https://github.com/lviggiano/owner/tree/master/owner-site

You can add some lines to an existing page, or I will do it after I merge this change.

Thanks for your patience; and sorry for the delay. This long delay happens because I am having health issues that keeps me away from work and hobbies.

Luigi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants