Object disposed before async method completes

[QualityControll]

couchdb-net/src/CouchDB.Driver/Extensions/FlurlRequestExtensions.cs

Line 27 in a2f5ad0

using var capturedJsonContent = new CapturedJsonContent(request.Settings.JsonSerializer.Serialize(data));

It looks like here and on line 45, the http content may be disposed before the async method completes, resulting in no http content being added to the request.

[matteobortolazzo]

Hi, did you identify a case when this happens consistently?

[n9]

@matteobortolazzo I think you are missing async/await there and in other places.

[n9]

You want to dispose after the task has been finished. (Not return pending task and dispose.)

[QualityControll]

Yes, n9 is correct, you should use async/await instead of returning the task without awaiting it.

I noticed this bug when I called 'GetContinuousChangesAsync' with a filter expression.

[matteobortolazzo]

To be honest, that part is copied from Flurl itself. Can you create a PR on this? As I am not sure how to test it / why it's a problem to return the task since I don't need the result in there

[n9]

@matteobortolazzo Could you please provide permalink to code in Flurl repo that you copied. (Just one method.)

[matteobortolazzo]

@n9 hi, I think from here https://github.com/tmenier/Flurl/blob/188999bca44b7acb4270f428a2c5374dbf130476/src/Flurl.Http/GeneratedExtensions.cs#L158

[n9]

@matteobortolazzo The Flurl code is ok - there is no using there. But your code have using without await.

[matteobortolazzo]

I feel so stupid. I get what you mean now...