Fixes Bad Request on Attachment Upload #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nefarius, thanks a lot for the PR! I get how this solves the 400, but if you ignore attachments, how do you upload them? Or I am missing something? |
|
The upload happens in a separate call immediately after you submitted the document. The CouchDB Server then updates the document JSON with the new attachment. This crashed before, now it works and then the attachment upload happens. |
|
My bad, it's so long I forgot! Do you need a package release after the merge? |
No worries, I'd like to see this lib come to perfection, and since I'll use it in an ongoing project I'll PR stuff if I find bugs 😁
That would be delightful. |
|
Preview 3 uploaded 🙂 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
CouchDB v3.2.1 (in my test scenario) refuses a document update when one or more attachments were added because of incomplete attachment meta data created by the serializer. I solved this by adding a JSON converter which ignores new attachments in the PUT request.