Support querying with single item array #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borigas
changed the title
matteobortolazzo
approved these changes
Apr 25, 2019
Owner
matteobortolazzo
left a comment
matteobortolazzo
left a comment
There was a problem hiding this comment.
Nice finding!
You are right, it was only for UseIndex, now is much better.
Thank you Ben.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_rebels.Where(r => r.Age.In(new[] { 20 }))was querying with{"age":{"$in":20}}}, which CouchDb doesn't like. It looks like the special handling of 1 item arrays was in there forUseIndex(), so I moved that special case handling to UseIndex and let the rest of arrays include square brackets.The last commit removes the 2nd constant handler and shares the 1st to reduce duplication. The change isn't strictly necessary, but I think it increases maintainability. If there's a side effect I'm not aware of, I'm happy to revert that