Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTF-8 BOM support #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fanweixiao
Copy link

I don't know if is right that adding a parameter called options, so I just send a PR with utf8 BOM support, .csv file should be away from encoding problems

Review on Reviewable

@matteofigus
Copy link
Owner

Line 52: fanweixiao@a3e4815#diff-1f8bcb5be7db7c497bfc0d8166c2bd70L52 should be fixing this. Can you explain a little better what are you trying to fix? What version of node and express are you using to get this problem?

@matteofigus
Copy link
Owner

DIdn't got an answer about this question, so I'm closing this. In case you want to clarify, can you open another issue? Thanks.

@matteofigus matteofigus closed this Dec 3, 2014
@fanweixiao
Copy link
Author

Sorry for did not reply immediately. I encountered problems when opening .csv file by Mac Office Excel in chinese, I added utf8 BOM to resolve this.

@matteofigus
Copy link
Owner

It would be very helpful if you could include:

  • an input
  • the output for that input (with the error)
  • the expected output

In that case, I would be able to create a failing test and then work on the fix.

Thanks
Matteo

@matteofigus matteofigus reopened this Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants