Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with migration changes #25

Merged
merged 10 commits into from
Apr 21, 2024
Merged

Conversation

ATK422
Copy link
Contributor

@ATK422 ATK422 commented Jan 19, 2024

Changed everything from evaera/matter to matter-ecs/matter. Reworked the installation guide. Added Migration steps.

Proposed changes

I went through and reworked some of the documentation to reflect changes to the org.

Related issues

Resolves #23

Changed everything from evaera/matter to matter-ecs/matter. Reworked the installation guide. Added Migration steps.
@ATK422 ATK422 mentioned this pull request Jan 21, 2024
jackTabsCode
jackTabsCode previously approved these changes Jan 26, 2024
@LastTalon LastTalon changed the title Documentation Changes Update documentation with migration changes Jan 26, 2024
Copy link
Member

@LastTalon LastTalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I just have a few changes I'd like before merging.

Mainly, the use of actual valid version numbers is useful people who are just going to copy things to get started quickly.

docs/Guides/MatterDebugger.md Outdated Show resolved Hide resolved
docs/Guides/Migration.md Outdated Show resolved Hide resolved
docs/Installation.md Outdated Show resolved Hide resolved
@jackTabsCode jackTabsCode added documentation Improvements or additions to documentation improvement An imperfection we can make better labels Jan 27, 2024
@ATK422
Copy link
Contributor Author

ATK422 commented Jan 28, 2024

All the changes look good

@LastTalon
Copy link
Member

All the changes look good

It looks like you just resolved the issues without merging any suggested changes. Could you try to unresolve them to see if you can add them?

@jackTabsCode jackTabsCode removed documentation Improvements or additions to documentation improvement An imperfection we can make better labels Jan 28, 2024
ATK422 and others added 2 commits January 29, 2024 21:21
Co-authored-by: Lucas Gangstad <lucas@lasttalon.dev>
ATK422 and others added 2 commits January 29, 2024 21:22
Co-authored-by: Lucas Gangstad <lucas@lasttalon.dev>
Co-authored-by: Lucas Gangstad <lucas@lasttalon.dev>
@ATK422
Copy link
Contributor Author

ATK422 commented Jan 30, 2024

Should be fixed now, sorry about that.

docs/Installation.md Outdated Show resolved Hide resolved
Co-authored-by: Lucas Gangstad <lucas@lasttalon.dev>
@ATK422
Copy link
Contributor Author

ATK422 commented Feb 2, 2024

Alright, committed it.

@Ukendio Ukendio requested a review from LastTalon February 15, 2024 23:33
@LastTalon LastTalon removed their request for review April 21, 2024 21:42
Copy link
Member

@LastTalon LastTalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be fine to me.

@LastTalon LastTalon merged commit 958ca63 into matter-ecs:main Apr 21, 2024
6 checks passed
Ukendio added a commit that referenced this pull request Apr 21, 2024
Co-authored-by: ATK <54485972+ATK422@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website guide is out of date
4 participants