Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds query views #31

Merged
merged 28 commits into from
Apr 22, 2024
Merged

Adds query views #31

merged 28 commits into from
Apr 22, 2024

Conversation

Ukendio
Copy link
Member

@Ukendio Ukendio commented Jan 29, 2024

This is just one way to resolve #2 where we could potentially extend the API instead of changing queryResult:snapshot(). Currently the order of entities is undefined and may differ from a query or snapshot. Maybe we can fix this by using linked lists or something, need thoughts on this.

TODO

@Ukendio Ukendio added the feature New feature or request label Jan 29, 2024
@Ukendio Ukendio modified the milestones: v0.7.2, v0.8.0 Feb 2, 2024
lib/World.lua Outdated Show resolved Hide resolved
Copy link
Contributor

@metrowaii metrowaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ukendio Ukendio merged commit f11b192 into main Apr 22, 2024
6 checks passed
@Ukendio Ukendio deleted the adds-query-views branch April 22, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot should return a "View" Handle
3 participants