-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds account configuration options #388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks really good!
…ra-test-node into db/add-account-cli-options
popzxc
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Dependencies:
alloy-signer-local
andalloy-signer
dependencies to support account generation and signing.rand
dependency to support random number generation for account mnemonics.Configuration and CLI:
examples/config.toml
file and the ability to set config value via toml file. When users attempt to use--config
a warning is displayed indicating its deprecated.Cli
struct insrc/config/cli.rs
to include options for generating and configuring accounts, such asaccounts
,balance
,mnemonic
,mnemonic_random
,mnemonic_seed
, andderivation_path
.TestNodeConfig:
TestNodeConfig
insrc/config/mod.rs
to include fields for account generation and management, such asgenesis_accounts
,signer_accounts
, andaccount_generator
.TestNodeConfig
for setting genesis accounts, signer accounts, and account generatorfn override_with_opts
in favour ofto_test_node_config
Main Function:
src/main.rs
to use the newto_test_node_config
method from theCli
structWhy ✋
Evidence 📷
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intended