refactor: separate block sealing logic from executing txs #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Hefty refactoring of block sealing into its own logical layer on top of tx execution. This opens up a way to support several txs per block and dynamic block sealing in general. This PR also gets rid of all the ad-hoc empty block logic and instead replaces them with
seal_block([]). Making us have a centralized place where all the blocks are created and thus this PR closes #358The code is still pretty messy but I want to gradually improve it as I suspect many things here will go into separate subcomponents (e.g.
BlockSealer,BatchSealeretc)Why ✋
Entangled sealing logic made it very hard to make it customizable for #362