Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds-host-cli-option #395

Merged
merged 7 commits into from
Nov 25, 2024
Merged

feat: adds-host-cli-option #395

merged 7 commits into from
Nov 25, 2024

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Nov 20, 2024

What 💻

  • src/config/cli.rs: Added a new host field to the Cli struct, allowing the server to listen on multiple IP addresses.
  • Updated the impl Cli to include the new host field in the configuration.
  • src/config/mod.rs: Added a new host field to the TestNodeConfig struct and updated its default implementation. Modified the print method to display all hosts and added a new with_host method to set the hosts.
  • src/main.rs: Updated the main function to handle multiple hosts by iterating over the config.host field and creating a SocketAddr for each host.

Why ✋

  • Aligns with Anvil
  • Adds flexibility in configurability

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@dutterbutter dutterbutter marked this pull request as ready for review November 20, 2024 18:42
@dutterbutter dutterbutter requested a review from a team as a code owner November 20, 2024 18:42
itegulov
itegulov previously approved these changes Nov 22, 2024
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small nit

src/config/cli.rs Show resolved Hide resolved
@dutterbutter dutterbutter merged commit 2b24554 into main Nov 25, 2024
11 checks passed
@dutterbutter dutterbutter deleted the db/add-host-option-cmd branch November 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👓 PR requires a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants