test: integration tests migrated signed #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# What ❔ Removes initial "/" from "Contract Path" placeholder. ## Why ❔ Contract verification fails if path "/contracts/Greeter.sol" is provided instead of "contracts/Greeter.sol" ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated.
# What ❔ Custom base token support. ## Why ❔ Since the Era network now supports custom base tokens, the explorer should also support them. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated. --------- Co-authored-by: SantiagoPittella <pittellasantiago@gmail.com> Co-authored-by: Santiago Pittella <87827390+SantiagoPittella@users.noreply.github.com> Co-authored-by: ilitteri <ilitteri@fi.uba.ar>
# What ❔ Update uptime url ## Why ❔ Previous url is outdated and was taken over for security report bug bounty Co-authored-by: Antonio <tonioufa@gmail.com>
# What ❔ Adding missing baseTokenAddress to the hyperchain configuration. Adding a fallback to use the default L2 base token address if it's not specified in the config. ## Why ❔ When configuring the block explorer using npm run hyperchain:configure, the resulting configuration was missing the baseTokenAddress value. This absence was causing an error [here](https://github.com/matter-labs/block-explorer/blob/main/packages/app/src/composables/useEnvironmentConfig.ts#L31). As a result of this error, the system was defaulting to Sepolia (which I assume is not the intended behavior for your hyperchain setup). ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated. - [X] Documentation comments have been added / updated. --------- Signed-off-by: Vasyl Ivanchuk <vasyl.ivanchuk@gmail.com> Co-authored-by: Alexander Melnikov <sanekmelnikov@gmail.com>
pcheremu
changed the base branch from
main
to
integration-tests-ether-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Signed and rebased: #269
Checklist