Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: value argument is not being properly passed to the contract call #292

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What ❔

Fix next contract interaction issues:

  1. Cant write to contract: #255
  2. fix for default max gas on payable functions #286

Why ❔

To fix contract interaction issues.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.

Copy link

github-actions bot commented Oct 10, 2024

API E2E Test Results

207 tests   207 ✅  20s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 96a43c6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 10, 2024

Unit Test Results

    4 files    263 suites   11m 49s ⏱️
2 090 tests 2 089 ✅ 1 💤 0 ❌
2 299 runs  2 298 ✅ 1 💤 0 ❌

Results for commit 96a43c6.

♻️ This comment has been updated with latest results.

Copy link

Visit the preview URL for this PR:
https://staging-scan-v2--pr-292-ja4nngkr.web.app

./allurectl upload allure-results
echo "*Public report link: https://raw.githack.com/matter-labs/block-explorer/gh-pages/${{ github.run_number }}/index.html"
echo "*Public report link will be available when the 'Allure Report' job will be succesfully executed."
# - name: Upload test results to Allure reporter
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable this GH action step for the time being as it fails for some reason. It will be investigated and fixed in the following PRs.

@vasyl-ivanchuk vasyl-ivanchuk merged commit a838825 into main Oct 10, 2024
23 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the fix-contract-interactions branch October 10, 2024 13:18
Copy link

🎉 This PR is included in version 2.49.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants