chore: publish preview url only for the base repo prs #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API E2E Test Results207 tests 207 ✅ 19s ⏱️ Results for commit 1c70d1f. |
Unit Test Results 4 files 263 suites 11m 21s ⏱️ Results for commit 1c70d1f. |
|
Visit the preview URL for this PR: |
popzxc
approved these changes
Nov 11, 2024
|
🎉 This PR is included in version 2.50.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Publish preview url only for the base repo PRs.
Why ❔
Even though
pull-requests: writepermissions are specified for theBuild and Test AppGitHub workflow, forked PRs are executed underpull-requests: readpermissions. This causes thePublish preview URLaction to fail, as it attempts to add a comment to the PR. Using thepull_request_targetevent instead ofpull_requestis not an option, as the workflow builds and runs code from the pull request context. To resolve this, thePublish preview URLaction was modified to run only for base repository PRs. This should not be a problem for the forked PRs, as the URL is still output to the GitHub Action logs.Checklist