fix: rename tx created field to tx received at #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API E2E Test Results207 tests 207 ✅ 19s ⏱️ Results for commit 8d7cd59. |
Unit Test Results 4 files 263 suites 11m 18s ⏱️ Results for commit 8d7cd59. |
|
Visit the preview URL for this PR: |
Romsters
approved these changes
Dec 3, 2024
|
🎉 This PR is included in version 2.55.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
tx-nikola
pushed a commit
that referenced
this pull request
Dec 4, 2024
# What ❔ Rename tx created field to tx received at, fix the tooltip for the field. ## Why ❔ The new name better reflects the purpose of the value. As for the tooltip, it was misleading, as it stated that the displayed time was when the transaction was added to the block, which is incorrect. The datetime shown is actually the time when the transaction was received. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
tx-nikola
pushed a commit
that referenced
this pull request
Dec 4, 2024
# What ❔ Rename tx created field to tx received at, fix the tooltip for the field. ## Why ❔ The new name better reflects the purpose of the value. As for the tooltip, it was misleading, as it stated that the displayed time was when the transaction was added to the block, which is incorrect. The datetime shown is actually the time when the transaction was received. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Rename tx created field to tx received at, fix the tooltip for the field.
Why ❔
The new name better reflects the purpose of the value. As for the tooltip, it was misleading, as it stated that the displayed time was when the transaction was added to the block, which is incorrect. The datetime shown is actually the time when the transaction was received.
Checklist