test: add .env.example file with its description to integration-tests Readme.md #58
Conversation
pcheremu
changed the title
pcheremu
changed the title
|
Visit the preview URL for this PR (updated for commit 6e62c51):
(expires Thu, 26 Oct 2023 13:20:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
|
|
||
| import type { HardhatUserConfig } from "hardhat/types"; | ||
|
|
||
| const envFilePath = `${__dirname}/.env`; |
There was a problem hiding this comment.
We shouldn't do any file existence checks. We should just have a fallback to Wallets.richWalletPrivateKey. No logic is needed here in this file except loading dotenv.
There was a problem hiding this comment.
Fallback logic should be used in place where process.env.WALLET_PRIVATE_KEY is used
|
|
||
| import type { HardhatUserConfig } from "hardhat/types"; | ||
|
|
||
| if (!process.env.WALLET_PRIVATE_KEY) { |
There was a problem hiding this comment.
No need for this check and reassigning env vars is a bad pattern. I meant you can add a fallback in the place where it is used.
Like:
const wallet = new Wallet(process.env.WALLET_PRIVATE_KEY || Wallets.richWalletPrivateKey);
...
There was a problem hiding this comment.
Updated, thank you. @Romsters
What ❔
env.example file with Readme description to integration-tests
Why ❔
To improve UX and avoid issues in preparing a local env
Checklist
env.example
Readme.md
[ + ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ n\a ] Tests for the changes have been added / updated.
[ + ] Documentation comments have been added / updated.