forked from JackHamer09/zksync-plus
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add retry and check using new sdk method for finalization #194
Draft
dutterbutter
wants to merge
2
commits into
main
Choose a base branch
from
db/fix-193
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−8
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,6 +122,13 @@ export default (transactionInfo: ComputedRef<TransactionInfo>) => { | |
} | ||
const wallet = await onboardStore.getWallet(); | ||
const { transactionParams, gasLimit, gasPrice } = (await estimateFee())!; | ||
|
||
// Check if the batch has been processed before attempting finalization | ||
const l1BatchNumber = finalizeWithdrawalParams.value?.l1BatchNumber; | ||
if (l1BatchNumber && !(await isBatchProcessed(l1BatchNumber))) { | ||
throw new Error("Batch not yet processed. Please wait and try again later."); | ||
} | ||
|
||
status.value = "waiting-for-signature"; | ||
transactionHash.value = await wallet.writeContract({ | ||
...transactionParams, | ||
|
@@ -130,13 +137,16 @@ export default (transactionInfo: ComputedRef<TransactionInfo>) => { | |
}); | ||
|
||
status.value = "sending"; | ||
const receipt = await retry(() => | ||
onboardStore.getPublicClient().waitForTransactionReceipt({ | ||
hash: transactionHash.value!, | ||
onReplaced: (replacement) => { | ||
transactionHash.value = replacement.transaction.hash; | ||
}, | ||
}) | ||
const receipt = await retry( | ||
async () => { | ||
return await onboardStore.getPublicClient().waitForTransactionReceipt({ | ||
hash: transactionHash.value!, | ||
onReplaced: (replacement) => { | ||
transactionHash.value = replacement.transaction.hash; | ||
}, | ||
}); | ||
}, | ||
{ retries: 3, delay: 10000 } | ||
); | ||
|
||
trackEvent("withdrawal-finalized", { | ||
|
@@ -166,3 +176,16 @@ export default (transactionInfo: ComputedRef<TransactionInfo>) => { | |
commitTransaction, | ||
}; | ||
}; | ||
|
||
const isBatchProcessed = async (batchNumber: any) => { | ||
const providerStore = useZkSyncProviderStore(); | ||
try { | ||
const totalBatchesExecuted = await providerStore.requestProvider().getTotalBatchesExecuted(); | ||
|
||
return batchNumber <= BigNumber.from(totalBatchesExecuted).toNumber(); | ||
} catch (error) { | ||
// eslint-disable-next-line no-console | ||
console.error("Error fetching total batches executed:", error); | ||
return false; | ||
} | ||
}; | ||
Comment on lines
+180
to
+191
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem necessary as it doesnt seem to be the root of the issue.
Wallet.isWithdrawalFinalized()
is used already and provides that check for withdrawal finalization