Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

feat: Make boojum compile with modern compiler #57

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 5, 2024

What ❔

  • slice_flatten has been stabilized with different function names.
    This unblocks usage of modern nightly.

  • Removes old code that used packed_simd for optimizations. It makes use of u128x4, so it can't easily be ported to std::simd.

Why ❔

To not be stuck with the old compiler.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@0xVolosnikov
Copy link
Contributor

Seems like nightly-2023-05-31 is hardcoded for macos-13-xlarge

@popzxc
Copy link
Member Author

popzxc commented Aug 5, 2024

Ah, huh, packed_simd... This is going to be interesting :)

@popzxc popzxc force-pushed the popzxc-make-boojum-compile branch from 4be44a1 to f88506c Compare August 5, 2024 13:22
@popzxc popzxc requested a review from shamatar August 5, 2024 13:49
@popzxc popzxc merged commit 5cd7711 into main Aug 5, 2024
5 checks passed
@popzxc popzxc deleted the popzxc-make-boojum-compile branch August 6, 2024 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants