feat: getBytecodeByHash robustness #1000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nbaztec
reviewed
Mar 31, 2025
|
|
||
| /// The delay (in seconds) betwen each retry to | ||
| /// retrieve code_by_hash from forked DB | ||
| const CODE_BY_HASH_RETRY_DELAY_SECS: u64 = 3; |
There was a problem hiding this comment.
Please make this a Duration
| /// retrieve code_by_hash from forked DB | ||
| const CODE_BY_HASH_RETRIES: u32 = 3; | ||
|
|
||
| /// The delay (in seconds) betwen each retry to |
There was a problem hiding this comment.
Suggested change
| /// The delay (in seconds) betwen each retry to | |
| /// The delay (in seconds) between each retry to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Add error trace when bytecodeByHash RPC call failsbytecodeByHashRPC failsWhy ✋
Evidence 📷
Documentation 📚
Please ensure the following before submitting your PR:
Notes 📝
I originally tried to mock all requests to the server but it ended up being massive quickly (about the 6th request when it asked for the code of a system contract), so instead I added this MITM mode to our
MockServerso we can override specific requests (in this case,zks_getBytecodeByHash) and forward all the rest to a target node.I didn't change the other usages of
MockServerto the new builder, just to avoid changing a bunch of files that are irrelevant, but we can do that here if we want to be consistent with usage.