Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix and revise docker push strategy #117

Merged
merged 5 commits into from
Jun 12, 2024
Merged

ci: fix and revise docker push strategy #117

merged 5 commits into from
Jun 12, 2024

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Jun 12, 2024

  • fix: don't tag the nix produced container with latest
  • feat: add container-vault-admin
  • fix(container-vault-unseal): remove azure config
    Not needed anymore. Stuff can be gathered via the default qpl
  • docs(examples): fix the container names
  • containers are not latest by default anymore
  • latest tag is only set on push to main branch
  • buildid tag is only set on push to main branch, and
    changed to the infra repo soonish
  • added the missing vault-unseal and vault-admin container

haraldh added 4 commits June 12, 2024 13:21
leave it to the github workflow on push to main

Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
Not needed anymore. Stuff can be gathered via the default qpl

Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
@haraldh haraldh marked this pull request as ready for review June 12, 2024 11:54
@haraldh haraldh requested a review from a team as a code owner June 12, 2024 11:54
- containers are not `latest` by default anymore
- `latest` tag is only set on push to main branch
- buildid tag is only set on push to main branch, and
  changed to the infra repo soonish
- added the missing `vault-unseal` and `vault-admin` container

Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
@haraldh haraldh enabled auto-merge June 12, 2024 12:22
@haraldh haraldh merged commit 8e17599 into main Jun 12, 2024
13 checks passed
@haraldh haraldh deleted the container-push branch June 12, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants