Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use sepolia for hello world #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use sepolia for hello world #32

wants to merge 1 commit into from

Conversation

vincentes
Copy link

@vincentes vincentes commented Jan 26, 2024 •
edited
Loading

What 💻

  • Updated current Metamask network if statement to check for chain id 300 (zkSync Sepolia).

Why ✋

  • The whole documentation makes references to Sepolia, but the Metamask condition is still checking for zkSync Goerli. I spent a few minutes trying to figure out the issue.

Evidence 📷

  • I don't think this is needed.

Notes 📝

  • I didn't find contribution guidelines, let me know if this is the right channel.

@vincentes vincentes requested a review from a team as a code owner January 26, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsacoyote itsacoyote itsacoyote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentes @itsacoyote