fix: better CUDA detection #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkolasg
approved these changes
Dec 11, 2024
delehef
force-pushed
the
fix/cuda-version-detection
branch
from
c20bdf5 to
3ffdcf3
Compare
delehef
force-pushed
the
fix/cuda-version-detection
branch
from
3ffdcf3 to
3c409f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR improves the detection of the CUDA toolkit under Linux, and the detection of its version under all OSes.
Why ❔
Under Linux, the CUDA detection is hardcoded to look into
/usr/local/cuda, which is not guaranteed to be the default installation folder. The new method first looks for theCUDA_PATHenv. var., then default to/usr/local/cudaif it is empty.The current way of finding out the installed CUDA version is to look for a
version.jsonfile in the CUDA installation path. This file is not guaranteed to exist. However,nvccis guaranteed to be installed with the toolkit; so the new method is to parse its output to find the exact version there.Checklist
zk fmtandzk lint.