Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(franklin-crypto): add extern crate core; to lib.rs #27

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

RomanBrodetski
Copy link
Contributor

I wasn't able to quickly switch to newer edition Rust in this repo.
This statement in lib.rs fixes my dependency issues on era side.

Please LMK if there are any reprecussions of this.

@RomanBrodetski RomanBrodetski requested a review from popzxc October 8, 2024 10:57
@RomanBrodetski RomanBrodetski changed the title add extern crate core; to lib.rs feat(build): add extern crate core; to lib.rs Oct 8, 2024
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the PR scope to feat(franklin-crypto)

@RomanBrodetski RomanBrodetski changed the title feat(build): add extern crate core; to lib.rs feat(franklin-crypto): add extern crate core; to lib.rs Nov 25, 2024
@RomanBrodetski RomanBrodetski merged commit 3084cb8 into main Nov 25, 2024
7 checks passed
@RomanBrodetski RomanBrodetski deleted the rb-export-crate-core branch November 25, 2024 11:29
RomanBrodetski pushed a commit that referenced this pull request Nov 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.30.10](v0.30.9...v0.30.10)
(2024-11-27)


### Features

* **franklin-crypto:** add `extern crate core;` to lib.rs
([#27](#27))
([3084cb8](3084cb8))


### Bug Fixes

* Disabled vectorisation for neon
([#52](#52))
([3900a4b](3900a4b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants