Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local paths for in-workspace dependencies #7

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Use local paths for in-workspace dependencies #7

merged 3 commits into from
Aug 15, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 15, 2024 •
edited
Loading

⚠️ diff is huge because of cargo fmt on crates added to the workspace (see below).

With this change, changing the local crate would affect other crates in the workspace.
E.g. with this, you can change several crates in one go.

Also, it flattens the (previously nested) structure:

  • ff_derive and cs_derive moved from ff and boojum correspondingly.
  • ff_derive_const is removed as unused.

Readme updated as well.

@popzxc popzxc requested a review from EmilLuta August 15, 2024 06:18
@popzxc popzxc merged commit df70186 into main Aug 15, 2024
3 checks passed
@popzxc popzxc deleted the popzxc-setup-workspace branch August 15, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilLuta EmilLuta EmilLuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popzxc @EmilLuta