Skip to content

Commit

Permalink
feat(zkstack_cli): Add more folders to containers' PATH (#3057)
Browse files Browse the repository at this point in the history
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk_supervisor fmt` and `zk_supervisor
lint`.
  • Loading branch information
manuelmauro authored Oct 10, 2024
1 parent db133e6 commit 2bf74b6
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
1 change: 1 addition & 0 deletions docker/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ prepare-contracts: check-tools check-contracts
@cd ../ && \
export ZKSYNC_HOME=$$(pwd) && \
export PATH=$$PATH:$${ZKSYNC_HOME}/bin && \
export PATH=$$PATH:$${ZKSYNC_HOME}/zkstack_cli/zkstackup && \
zkt || true && \
zk_supervisor contracts && \
mkdir -p contracts/l1-contracts/artifacts
Expand Down
4 changes: 3 additions & 1 deletion docker/zk-environment/20.04_amd64_cuda_11_8.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ RUN wget -c https://sourceware.org/pub/valgrind/valgrind-3.20.0.tar.bz2 && \

# Setup the environment
ENV ZKSYNC_HOME=/usr/src/zksync
ENV PATH="${ZKSYNC_HOME}/bin:${PATH}"
ENV PATH="${ZKSYNC_HOME}/bin:${PATH}" \
PATH="${ZKSYNC_HOME}/zkstack_cli/zkstackup:${PATH}" \
PATH="${HOME}/.local/bin:${PATH}"
ENV CI=1
RUN cargo install sccache
ENV RUSTC_WRAPPER=/usr/local/cargo/bin/sccache
Expand Down
4 changes: 3 additions & 1 deletion docker/zk-environment/20.04_amd64_cuda_12_0.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ RUN wget -c https://github.com/matter-labs/zksolc-bin/raw/main/linux-amd64/zksol

# Setup the environment
ENV ZKSYNC_HOME=/usr/src/zksync
ENV PATH="${ZKSYNC_HOME}/bin:${PATH}"
ENV PATH="${ZKSYNC_HOME}/bin:${PATH}" \
PATH="${ZKSYNC_HOME}/zkstack_cli/zkstackup:${PATH}" \
PATH="${HOME}/.local/bin:${PATH}"
ENV CI=1
RUN cargo install sccache
ENV RUSTC_WRAPPER=/usr/local/cargo/bin/sccache
Expand Down
4 changes: 3 additions & 1 deletion docker/zk-environment/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ RUN wget -c https://sourceware.org/pub/valgrind/valgrind-3.20.0.tar.bz2 && \

# Setup the environment
ENV ZKSYNC_HOME=/usr/src/zksync
ENV PATH="${ZKSYNC_HOME}/bin:${PATH}"
ENV PATH="${ZKSYNC_HOME}/bin:${PATH}" \
PATH="${ZKSYNC_HOME}/zkstack_cli/zkstackup:${PATH}" \
PATH="${HOME}/.local/bin:${PATH}"
ENV CI=1
ENV RUSTC_WRAPPER=/usr/local/cargo/bin/sccache

Expand Down

0 comments on commit 2bf74b6

Please sign in to comment.