fix(vm-runner): make last_ready_batch account for `first_processed_…

…batch` (#2238)

## What ❔

Fixes a bug that is currently being observed on testnet

## Why ❔

Previously, on a fresh start, `last_ready_batch` could report incorrect
batch meaning no progress would be made as `last_ready_batch` would be
far less than `first_processed_batch`.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
- [x] Spellcheck has been run via `zk spellcheck`.

core/lib/dal/src/vm_runner_dal.rs

@@ -31,6 +31,7 @@ impl VmRunnerDal<'_, '_> {
 
     pub async fn get_protective_reads_last_ready_batch(
         &mut self,
+        default_batch: L1BatchNumber,
         window_size: u32,
     ) -> DalResult<L1BatchNumber> {
         let row = sqlx::query!(
@@ -44,7 +45,7 @@ impl VmRunnerDal<'_, '_> {
                 ),
                 processed_batches AS (
                     SELECT
-                        COALESCE(MAX(l1_batch_number), 0) + $1 AS "last_ready_batch"
+                        COALESCE(MAX(l1_batch_number), $1) + $2 AS "last_ready_batch"
                     FROM
                         vm_runner_protective_reads
                 )
@@ -54,6 +55,7 @@ impl VmRunnerDal<'_, '_> {
                 available_batches
                 FULL JOIN processed_batches ON TRUE
             "#,
+            default_batch.0 as i32,
             window_size as i32
         )
         .instrument("get_protective_reads_last_ready_batch")

core/node/vm_runner/src/impls/protective_reads.rs

@@ -104,7 +104,7 @@ impl VmRunnerIo for ProtectiveReadsIo {
     ) -> anyhow::Result<L1BatchNumber> {
         Ok(conn
             .vm_runner_dal()
-            .get_protective_reads_last_ready_batch(self.window_size)
+            .get_protective_reads_last_ready_batch(self.first_processed_batch, self.window_size)
             .await?)
     }