Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase number of connections for local postgres #1023

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Feb 7, 2024

What ❔

  • Increases max_connections in postgres (locally) from 100 to 200.
  • Hopefully, it'll reduce the problems with integration tests in CI.

Why ❔

  • A single server (main node or EN) instance by default uses a connection pool size of 50, and it spawns several additional unique connections, making the total slightly higher than 50.
  • In integration tests, we run the server and the EN simultaneously, resulting in more than 100 connections being utilized.
  • We recently bumped SQLx to 0.7, which seems to have problems with that.
  • ...with 200 connections supported, we will be below the threshold again, so it might help.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@popzxc popzxc requested a review from slowli February 7, 2024 07:24
@popzxc popzxc added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 908ac42 Feb 7, 2024
19 checks passed
@popzxc popzxc deleted the popzxc-reduce-postgres-issues-in-tests branch February 7, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants