-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Validium): refactor batch commit data generation #1325
Merged
ilitteri
merged 17 commits into
matter-labs:feat_validium_pubdata_abstraction
from
lambdaclass:feat_validium_data_commit_abstraction_v2
Mar 5, 2024
Merged
feat(Validium): refactor batch commit data generation #1325
ilitteri
merged 17 commits into
matter-labs:feat_validium_pubdata_abstraction
from
lambdaclass:feat_validium_data_commit_abstraction_v2
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
changed the title
feat: refactor batch commit data generation
feat(Validium): refactor batch commit data generation
Mar 1, 2024
… and `CommitBatchInfoRollup`
- First splits the functionality of `L1CommitBatchesDataGenerator::l1_commit_data` into two separate functions, one for a single batch and one for the whole array that includes the previous block. - Then uses that for publish criteria and consistency checking, as they work on a per-batch basis.
Oppen
force-pushed
the
feat_validium_data_commit_abstraction_v2
branch
from
March 4, 2024 18:19
693f4c4
to
2192b61
Compare
popzxc
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress here!
core/lib/l1_contract_interface/src/i_executor/methods/commit_batches.rs
Outdated
Show resolved
Hide resolved
core/lib/l1_contract_interface/src/i_executor/structures/commit_batch_info.rs
Outdated
Show resolved
Hide resolved
popzxc
approved these changes
Mar 5, 2024
…ion' into feat_validium_data_commit_abstraction_v2
ilitteri
merged commit Mar 5, 2024
941639d
into
matter-labs:feat_validium_pubdata_abstraction
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Reworks
L1BatchCommitDataGenerator
,CommitBatches
andCommitBatchInfo
.This PR moves most of the encoding responsibility to per-operation-mode
structures derived from
CommitBatches
andCommitBatchInfo
, modifyingtheir
Tokenize
implementations. In turn, theL1BatchCommitDataGenerator
implementations now differ only on which variant they instantiate to
delegate the request for tokenization.
After that, all aggregation logic and data generators is moved to
eth_sender
.The goal is to apply these recommendations.
NOTE: the following tests are failing both here and in the base branch:
Why ❔
The original changes for the L1 publish behaviour were a bit disperse over the
codebase, leading to hard to understand code and a more complex dependency graph.
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.