chore: Merge main to kl factory #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tomg10 <lemures64@gmail.com>
## What ❔ * Tool to create new genesis.yaml file * Update the genesis.yaml to v23 ## Why ❔ * To automate the process, before we introduce hyperchains. --------- Signed-off-by: Danil <deniallugo@gmail.com> Co-authored-by: Danil <deniallugo@gmail.com>
## What ❔ Extract `zksync_core::commitment_generator` to separate the crate in the node folder Put `zksync_commitment_utils` to `zksync_commitment_generator ` (reason: utils are used only by generator) ## Why ❔ Part of the "modularize the codebase" process, required for legolizer and publishing on crates.io. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`.
## What ❔ Brushes up the Ethereum Watcher component that was recently moved to its own crate. Wraps `sqlx` errors in the relevant DB queries. ## Why ❔ Simplifies maintenance. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`.
## What ❔ Fixes release-please config broken after #1584, by bumping the corresponding GitHub action. ## Why ❔ release-please shouldn't be broken. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
Includes a quickfix for the excessive throttling of p2p requests: matter-labs/era-consensus#95
## What ❔ Uses a singleton DB pool for scraping Postgres metrics instead of sharing the main pool. ## Why ❔ The main pool may be used at capacity (e.g., during snapshot recovery), which leads to timeouts collecting Postgres metrics. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`.
## What ❔ Miscellaneous brush-up after #1418 is merged. ## Why ❔ - Improves code maintainability. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`.
StanislavBreadless
requested review from
a team,
RomanBrodetski,
perekopskiy,
Deniallugo and
popzxc
as code owners
StanislavBreadless
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
and removed request for
a team
StanislavBreadless
changed the title
kelemeno
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Merge main into kl-factory
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.