fix(en): Remove duplicate reorg detector #1783

slowli · 2024-04-24T06:31:54Z

What ❔

Removes duplicate reorg detector initialization that sneaked in feat(en): Add boxed L2 client and use it in DI #1627 when updating the PR. Changes the health check API to detect duplicate components.
Fixes a race condition in the snapshot recovery test.

Why ❔

Running multiple reorg detectors (or multiple component instances in general) doesn't make sense.

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zk fmt and zk lint.
Spellcheck has been run via zk spellcheck.
Linkcheck has been run via zk linkcheck.

🤖 I have created a release *beep* *boop* --- ## [24.0.0](core-v23.1.0...core-v24.0.0) (2024-04-30) ### ⚠ BREAKING CHANGES * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) * shared bridge ([#298](#298)) ### Features * **api:** Allow granular max response size config ([#1642](#1642)) ([83c4034](83c4034)) * **api:** Improve logging for API server ([#1792](#1792)) ([50fbda5](50fbda5)) * **api:** Track params for RPC methods ([#1673](#1673)) ([1a34c8b](1a34c8b)) * **configs:** move ecosystem contracts to contracts ([#1606](#1606)) ([9d52180](9d52180)) * EcPairing precompile as system contract ([#1761](#1761)) ([3071622](3071622)) * Include create2 factory in genesis ([#1775](#1775)) ([597280b](597280b)) * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) ([6a557f7](6a557f7)) * **prover:** remove redundant config fields ([#1787](#1787)) ([a784ea6](a784ea6)) * shared bridge ([#298](#298)) ([8c3478a](8c3478a)) * **tree:** Improved tree pruning ([#1532](#1532)) ([bcb192c](bcb192c)) * **vm-runner:** implement VM runner storage layer ([#1651](#1651)) ([543f9e9](543f9e9)) * **vm:** Extend bootloader memory in the new version ([#1807](#1807)) ([f461b28](f461b28)) ### Bug Fixes * **api:** Fix extra DB connection acquisition during tx submission ([#1793](#1793)) ([9c6ed83](9c6ed83)) * **en:** correct en config vars ([#1809](#1809)) ([d340fbc](d340fbc)) * **en:** Remove duplicate reorg detector ([#1783](#1783)) ([3417941](3417941)) * **kl-factory:** base token ether tests ([#1746](#1746)) ([6cf14a0](6cf14a0)) * **prover:** Fix panics if prover's config is not ready ([#1822](#1822)) ([21d90d7](21d90d7)) * **snapshots_creator:** Remove snapshots during reverts ([#1757](#1757)) ([8d587fd](8d587fd)) * **types:** Add LegacyMixedCall ([#1773](#1773)) ([2b236fe](2b236fe)) * v23 api typo ([#1821](#1821)) ([a11fa86](a11fa86)) * Weaker assert for protocol version for operations ([#1800](#1800)) ([11898c2](11898c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: perekopskiy <mikeson.dp@gmail.com>

🤖 I have created a release *beep* *boop* --- ## [14.0.0](prover-v13.0.0...prover-v14.0.0) (2024-05-06) ### ⚠ BREAKING CHANGES * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) * shared bridge ([#298](#298)) ### Features * **config:** Wrap sensitive urls ([#1828](#1828)) ([c8ee740](c8ee740)) * **Prover CLI:** `status batch` command ([#1638](#1638)) ([3fd6d65](3fd6d65)) * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) ([6a557f7](6a557f7)) * **prover:** remove redundant config fields ([#1787](#1787)) ([a784ea6](a784ea6)) * shared bridge ([#298](#298)) ([8c3478a](8c3478a)) * **vm-runner:** implement VM runner storage layer ([#1651](#1651)) ([543f9e9](543f9e9)) ### Bug Fixes * **en:** Remove duplicate reorg detector ([#1783](#1783)) ([3417941](3417941)) * **prover:** Use all 1.5.0 groups for nodes ([#1851](#1851)) ([70178e5](70178e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

slowli added 6 commits April 23, 2024 22:53

Fix dependency spec

4d0af14

Fix extra reorg detector initialization

8657204

Check health check name on insertion

998f020

Fix race condition in snapshot recovery IT

57161af

Document / test health checks

5d17084

Update from upstream

943ba64

slowli marked this pull request as ready for review April 24, 2024 08:43

slowli requested review from montekki and RomanBrodetski April 24, 2024 08:43

montekki approved these changes Apr 24, 2024

View reviewed changes

montekki added this pull request to the merge queue Apr 24, 2024