feat(Prover CLI): Batch proof compression job status #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 24, 2024 20:45
…sync-era into prover_cli_compressor_status
EmilLuta
reviewed
Apr 25, 2024
| ) | ||
| .fetch_optional(self.storage.conn()) | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
I think we can use a map here for this one, very similar to get_oldest_not_compressed_batch approach.
Artemka374
reviewed
Apr 25, 2024
Artemka374
reviewed
Apr 25, 2024
| @@ -229,3 +230,33 @@ impl FromStr for GpuProverInstanceStatus { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, EnumString, Display)] | |||
| pub enum ProofCompressionJobStatus { | |||
There was a problem hiding this comment.
Isn't there a similar enum in types? May we reuse it here?
There was a problem hiding this comment.
Yes! This is the one that you are talking about, I just moved it to the right module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Handles the batch proof compression status for the
status batchcommand.Why ❔
A user that will do maintenance on the prover could find useful to see the batch proof compression job status.
Example
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.