Sync main with sync layer stable #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts remaining (strategically meaningful) parts of `zksync_core`. This was a hell of a feat to de-entangle all of these interdependencies (especially in tests, oh boy). The following crates were extracted: - zksync_node_test_utils - zksync_state_keeper - zksync_reorg_detector - zksync_consistency_checker - zksync_metadata_calculator - zksync_node_sync - zksync_node_consensus - zksync_contract_verification_server - zksync_node_api_server - zksync_tee_verifier_input_producer Contents of `zksync_core::utils` were moved to other places. `zksync_core` was renamed to `zksync_core_leftovers` (and will be removed when we migrate to the framework).⚠️ this is not a perfect PR. In some places, moving stuff to another location may not be fully idiomatic. In other places, the visibility of many items could've been reduced. However, it was TOUGH to get this PR even to this form, so let's focus on major issues. All the minor things are to be polished later. Once this is merged, I'll also update settings for infra to enable logs for new crates.
## What ❔ Only do a hex string conversion if serializer/deserializer `.is_human_readable()`. ## Why ❔ bincode does not need a hex string presentation. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
## What ❔ This PR creates a new abstraction `OutputHandlerFactory` that can orchestrate output handlers in a non-trivial manner. Specifically, for the purposes of VM runner we create an implementation `ConcurrentOutputHandlerFactory` that can produce delegated output handlers that internally use another output handler (i.e. delegatee is specific to the VM runner implementation). The main benefit of this implementation is that `handle_l1_batch` is non-blocking and finishes almost immediately. The actual work is spawned as a future and is then handled asynchronously enabling us to create many output handlers in parallel. ## Why ❔ One of the components for the upcoming VM runner ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`.
## What ❔ Docker image and CI for verified-sources-fetcher ## Why ❔ For use it as independent component ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`.
StanislavBreadless
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
and removed request for
a team
StanislavBreadless
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.