feat(en): Fetch old L1 batch hashes from L1 #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
May 22, 2024
perekopskiy
previously approved these changes
May 28, 2024
popzxc
approved these changes
May 31, 2024
|
@popzxc I was sure I've added metrics (thought about them as well) 🙃 Let me do that in a follow-up PR. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [24.6.0](core-v24.5.1...core-v24.6.0) (2024-06-03) ### Features * **en:** Fetch old L1 batch hashes from L1 ([#2000](#2000)) ([dc5a918](dc5a918)) * use semver for metrics, move constants to prover workspace ([#2098](#2098)) ([7a50a9f](7a50a9f)) ### Bug Fixes * **api:** correct default fee data in eth call ([#2072](#2072)) ([e71f6f9](e71f6f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
## What ❔ Adds a couple of metrics / logs for tree data fetcher related to fetching data from L1. Follow-up after #2000. ## Why ❔ These metrics / logs would allow to track tree data fetcher health more thoroughly. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fetches commitment hashes for old L1 batches from L1 instead of using a trusted L2 node.
Why ❔
This requires slightly less trust than a trusted L2 node. While the main node can theoretically write arbitrary hash to L1, it cannot equivocate, so a "fake" hash will be discovered soon enough, and it would be impossible to prove.
Checklist
zk fmtandzk lint.zk spellcheck.