fix(eth-watch): Do not track for stm, only for diamond proxy #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanislavBreadless
changed the title
perekopskiy
reviewed
May 30, 2024
There was a problem hiding this comment.
Looks good! Please update comments "Listens to operation events coming from the governance contract and saves new protocol upgrade proposals to the database.", "zkSync diamond proxy if pre-shared bridge; state transition manager if post shared bridge." near pub struct GovernanceUpgradesEventProcessor, IIUC they are outdated
|
@perekopskiy the first one is still correct as only ops from the governance are tracked |
3 tasks
kelemeno
approved these changes
May 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
🤖 I have created a release *beep* *boop* --- ## [24.5.0](core-v24.4.0...core-v24.5.0) (2024-05-30) ### Features * Add protocol_version label to WG jobs metric ([#2009](#2009)) ([e0a3393](e0a3393)) * **config:** remove zksync home ([#2022](#2022)) ([d08fe81](d08fe81)) * **en:** Improve tree snapshot recovery ([#1938](#1938)) ([5bc8234](5bc8234)) * Make house keeper emit correct protocol version ([#2062](#2062)) ([a58a7e8](a58a7e8)) * **node_framework:** Migrate main node to the framework ([#1997](#1997)) ([27a26cb](27a26cb)) * **node_framework:** Synchronize pools layer with logic in initialize_components ([#2079](#2079)) ([3202461](3202461)) * Protocol semantic version ([#2059](#2059)) ([3984dcf](3984dcf)) * **prover:** Adnotate prover queue metrics with protocol version ([#1893](#1893)) ([d1e1004](d1e1004)) * save writes needed for tree in state keeper ([#1965](#1965)) ([471af53](471af53)) * **test:** Add filebased config support for integration tests ([#2043](#2043)) ([be3ded9](be3ded9)) * **vm-runner:** implement VM runner main body ([#1955](#1955)) ([bf5b6c2](bf5b6c2)) ### Bug Fixes * **API:** polish web3 api block-related types ([#1994](#1994)) ([6cd3c53](6cd3c53)) * **en:** chunk factory deps ([#2077](#2077)) ([4b9e6fa](4b9e6fa)) * **en:** Fix recovery-related metrics ([#2014](#2014)) ([86355d6](86355d6)) * **eth-watch:** Do not track for stm, only for diamond proxy ([#2080](#2080)) ([87adac9](87adac9)) * fix metrics reporting wrong values ([#2065](#2065)) ([2ec010a](2ec010a)) * **loadtest:** resolve unit conversion error in loadtest metrics ([#1987](#1987)) ([b5870a0](b5870a0)) * **merkle-tree:** Fix incoherent Merkle tree view ([#2071](#2071)) ([2fc9a6c](2fc9a6c)) * **metadata-calculator:** protective reads sort ([#2087](#2087)) ([160c13c](160c13c)) * **node_framework:** Fix the connection pool size for the catchup task ([#2046](#2046)) ([c00a2eb](c00a2eb)) * **node_framework:** Use custom pool for commitiment generator ([#2076](#2076)) ([994df8f](994df8f)) * **protocol_version:** Add backward compatibility ([#2097](#2097)) ([391624b](391624b)) * **pruning:** Fix DB pruner responsiveness during shutdown ([#2058](#2058)) ([0a07312](0a07312)) * **zk_toolbox:** Use both folders for loading contracts ([#2030](#2030)) ([97c6d5c](97c6d5c)) ### Performance Improvements * **commitment-generator:** Run commitment generation for multiple batches in parallel ([#1984](#1984)) ([602bf67](602bf67)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
We plan to generally have all upgrades executed via a direct call to diamond proxy.
While in principle it is possible that an upgrade comes via a direct call through STM, this is a very rare circumstance and for now out of scope
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.