-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new commitments #219
Merged
perekopskiy
merged 7 commits into
main
from
perekopskiy-pla-621-add-events_queue_commitment
Oct 17, 2023
Merged
feat: Add new commitments #219
perekopskiy
merged 7 commits into
main
from
perekopskiy-pla-621-add-events_queue_commitment
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
changed the title
feat: Add new commitments
[WIP] feat: Add new commitments
Oct 13, 2023
perekopskiy
force-pushed
the
perekopskiy-pla-621-add-events_queue_commitment
branch
from
October 13, 2023 12:12
a046301
to
d7809d1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 32.27% 32.73% +0.45%
==========================================
Files 535 534 -1
Lines 28297 27818 -479
==========================================
- Hits 9133 9105 -28
+ Misses 19164 18713 -451
☔ View full report in Codecov by Sentry. |
mm-zk
reviewed
Oct 13, 2023
perekopskiy
force-pushed
the
perekopskiy-pla-621-add-events_queue_commitment
branch
from
October 16, 2023 08:50
43d0c0d
to
2d7c93c
Compare
perekopskiy
changed the title
[WIP] feat: Add new commitments
feat: Add new commitments
Oct 16, 2023
Deniallugo
reviewed
Oct 16, 2023
Deniallugo
reviewed
Oct 16, 2023
Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>
Deniallugo
reviewed
Oct 16, 2023
Detected VM performance changes
|
Deniallugo
approved these changes
Oct 17, 2023
perekopskiy
deleted the
perekopskiy-pla-621-add-events_queue_commitment
branch
October 17, 2023 08:16
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
🤖 I have created a release *beep* *boop* --- ## [16.1.0](core-v16.0.2...core-v16.1.0) (2023-10-24) ### Features * Add new commitments ([#219](#219)) ([a19256e](a19256e)) * arm64 zk-environment rust Docker images and other ([#296](#296)) ([33174aa](33174aa)) * **config:** Extract everything not related to the env config from zksync_config crate ([#245](#245)) ([42c64e9](42c64e9)) * **eth-watch:** process governor upgrades ([#247](#247)) ([d250294](d250294)) * **merkle tree:** Expose Merkle tree API ([#209](#209)) ([4010c7e](4010c7e)) * **merkle tree:** Snapshot recovery for Merkle tree ([#163](#163)) ([9e20703](9e20703)) * **multivm:** Remove lifetime from multivm ([#218](#218)) ([7eda27c](7eda27c)) * Remove fee_ticker and token_trading_volume fetcher modules ([#262](#262)) ([44f7179](44f7179)) * **reorg_detector:** compare miniblock hashes for reorg detection ([#236](#236)) ([2c930b2](2c930b2)) * Rewrite server binary to use `vise` metrics ([#120](#120)) ([26ee1fb](26ee1fb)) * **types:** introduce state diff record type and compression ([#194](#194)) ([ccf753c](ccf753c)) * **vm:** Improve tracer trait ([#121](#121)) ([ff60138](ff60138)) * **vm:** Move all vm versions to the one crate ([#249](#249)) ([e3fb489](e3fb489)) ### Bug Fixes * **crypto:** update snark-vk to be used in server and update args for proof wrapping ([#240](#240)) ([4a5c54c](4a5c54c)) * **db:** Fix write stalls in RocksDB ([#250](#250)) ([650124c](650124c)) * **db:** Fix write stalls in RocksDB (again) ([#265](#265)) ([7b23ab0](7b23ab0)) * **db:** Fix write stalls in RocksDB (for real this time) ([#292](#292)) ([0f15919](0f15919)) * Fix `TxStage` string representation ([#255](#255)) ([246b5a0](246b5a0)) * fix typos ([#226](#226)) ([feb8a6c](feb8a6c)) * **witness-generator:** Witness generator oracle with cached storage refunds ([#274](#274)) ([8928a41](8928a41)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
events_queue_commitment
andbootloader_initial_content_commitment
are calculated in full tree and saved into DB.Why ❔
Preparation for boojum upgrade
Checklist
zk fmt
andzk lint
.