feat(prover): Add port opt for prover #2375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand this is still in draft, but will comment on the idea. I'm having a hard time understanding what is moved to file based config and what belongs to CLI. Maybe an overlying reasoning for it wouldn't be bad. (this goes to file, this goes to CLI and file -- maybe it already exists somewhere?). My thought here is: I can totally understand why we want prometheus ports for things like WVG (when we test locally, we may start multiple of them), but then the rest are a bit weird (we run 1 per machine at all times in production and even locally). Not opposing the PR, just trying to understand better the decisions. Thanks in advance! |
|
Closed in favor of #2385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add port opt for prover