Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add revert tests (external node) to zk_toolbox #2408

Merged
merged 40 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
2de050a
wip: add revert en tests to zk_supervisor
aon Jul 1, 2024
0c60206
Fix typo
manuelmauro Jul 5, 2024
7757299
Format code
manuelmauro Jul 5, 2024
9c07368
Run nodes with config
manuelmauro Jul 8, 2024
f68833e
Format
manuelmauro Jul 8, 2024
106e0c7
Use correct operator account
manuelmauro Jul 9, 2024
108160c
Merge branch 'main' into aon-add-revert-en-tests-zk-supervisor
manuelmauro Jul 9, 2024
ef61851
Format
manuelmauro Jul 9, 2024
e6717e5
Source operator account from config
manuelmauro Jul 9, 2024
76cf2d2
Format
manuelmauro Jul 9, 2024
e044a68
Remove logging
manuelmauro Jul 9, 2024
6c9982e
Remove unnecessary sleep
manuelmauro Jul 9, 2024
3715176
Cover the case of env configuration when running external node
manuelmauro Jul 9, 2024
2da4b1e
Comment on edge cases
manuelmauro Jul 9, 2024
098013a
Remove unused env
manuelmauro Jul 9, 2024
dd0bbd3
Add CI test
manuelmauro Jul 10, 2024
60a6876
Add optional env parameter to runServerInBackground
manuelmauro Jul 10, 2024
552cbe3
Implement previous commit by duplicating utils
manuelmauro Jul 10, 2024
8c8798c
Reduce code duplication
manuelmauro Jul 10, 2024
4615df5
Use extEnv for block reverter
manuelmauro Jul 10, 2024
9aead67
Fix reverter conf
manuelmauro Jul 10, 2024
4294b14
Merge branch 'main' into aon-add-revert-en-tests-zk-supervisor
manuelmauro Jul 12, 2024
fa0ecda
Improve options type
manuelmauro Jul 12, 2024
7d6210c
Add sleep to reduce test flaky-ness
manuelmauro Jul 12, 2024
f8cb5f6
Format
manuelmauro Jul 12, 2024
15f71cf
Remove global test configuration
manuelmauro Jul 12, 2024
4590575
Do not rely on test timeote for node execution failure
manuelmauro Jul 12, 2024
06d0f97
Restore ExtNode.waitForExit
manuelmauro Jul 12, 2024
11c0270
Kill MainNode before alice.getBalance call
manuelmauro Jul 12, 2024
476c31b
Revert last commit
manuelmauro Jul 12, 2024
f7b0763
Reduce the chance of executing an extra batch before killing the server
manuelmauro Jul 12, 2024
d5b414f
Modify MainNode config on the fly by changing properties in conf files
manuelmauro Jul 15, 2024
0392740
Fix aggregated block prove deadline value
manuelmauro Jul 15, 2024
e9d73fe
Modify the right config property (aggregated_block_execute_deadline)
manuelmauro Jul 15, 2024
aac7164
Remove block_reverter pre-building step in CLI
manuelmauro Jul 15, 2024
b206fce
Lint
manuelmauro Jul 15, 2024
909ee12
Merge branch 'main' into aon-add-revert-en-tests-zk-supervisor
manuelmauro Jul 16, 2024
50abe0c
refactor: do not pre-build external node
manuelmauro Jul 22, 2024
c3a5cec
Merge branch 'main' into aon-add-revert-en-tests-zk-supervisor
manuelmauro Jul 22, 2024
f810616
test: remove sleep after external node restart
manuelmauro Jul 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci-zk-toolbox-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ jobs:
run: |
ci_run zk_supervisor test revert --ignore-prerequisites --verbose

- name: Run revert tests (external node)
run: |
ci_run zk_supervisor test revert --external-node --ignore-prerequisites --verbose

- name: Show server.log logs
if: always()
run: ci_run cat server.log || true
Expand Down
Loading
Loading